The Good, The Bad & The Ugly
© Daniel Deming, 2015
The Good: Collaboration
- No one is as smart as all of us
- Reducing the Bus Factor of the code
- Facilitates easy mentoring
The Good: Discipline & Change Controls
- Introduces structured code change review process
- Allow no one to merge their own commit
- Github model for collaboration
The Bad: Grammar Obsessed
- Style guides are important...
- ... but they can detract from bigger issues
The Bad: Time is Money
- When done properly, code reviews should take a long time
- This means less work gets done better
- The code you review is as important as the code you write yourself
The Ugly: "You're being stupid."
- Code reviews are the single biggest source of conflict in most Engineering Departments
- Don't argue "offline"
- Don't tell people what to do
- Don't fight for your own laziness
- Remember that you have to see these people every day
The Ugly: That time we wiped the servers